Skip to content

fix: remove all warnings from attribute access #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix: remove all warnings from attribute access #323

merged 2 commits into from
Nov 8, 2024

Conversation

@tdstein
Copy link
Collaborator

@tdstein tdstein commented Nov 8, 2024 •
edited
Loading

Removes all warning messages created by direct attribute access.

@github-actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1427 1356 95% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/posit/connect/bundles.py 98% 🟢
src/posit/connect/content.py 99% 🟢
src/posit/connect/groups.py 38% 🟢
src/posit/connect/permissions.py 100% 🟢
src/posit/connect/tasks.py 100% 🟢
src/posit/connect/users.py 96% 🟢
TOTAL 88% 🟢

updated for commit: 3a79cd2 by action🐍

@tdstein tdstein marked this pull request as ready for review November 8, 2024 01:24
@tdstein tdstein mentioned this pull request Nov 8, 2024
Merged
schloerke
schloerke reviewed Nov 8, 2024
View reviewed changes
schloerke
schloerke approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tdstein tdstein merged commit e507d3f into main Nov 8, 2024
33 checks passed
@tdstein tdstein deleted the tdstein/remove-warnings branch November 8, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schloerke schloerke schloerke approved these changes

@toph-allen toph-allen Awaiting requested review from toph-allen

@jonkeane jonkeane Awaiting requested review from jonkeane

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tdstein @schloerke